Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: xbmc/xbmc
base: 18.8-Leia
Choose a base ref
...
head repository: xbmc/xbmc
compare: 18.9-Leia
Choose a head ref
  • 17 commits
  • 19 files changed
  • 7 contributors

Commits on Jul 30, 2020

  1. Copy the full SHA
    571f9bb View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2020

  1. [cmake] fix build by remove quotation marks on ExternalProject values

    Before was about externalproject_add and related values quotation marks used.
    This breaks since cmake 3.18.0 his use (3.17.4 ok about).
    
    There it reports this by project related "PATCH_COMMAND ${PATCH_COMMAND}"
    as there a "" behind and seems to take this instead of patch path.
    
    Produced error message:
    ```
    patching file ''
    Hunk #1 FAILED at 16.
    1 out of 1 hunk FAILED -- saving rejects to file .rej
    /usr/bin/patch: **** Can't reopen file '' : No such file or directory
    ```
    
    This 2 values has used the quotation marks:
    INSTALL_COMMAND
    EXTERNALPROJECT_SETUP
    
    This remove them to have working again and fix e.g. Azure build system where
    takes this new version.
    AlwinEsch committed Aug 3, 2020
    Copy the full SHA
    8f714dc View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2020

  1. Merge pull request #18249 from AlwinEsch/fix-addon-build-2

    [Addon Helper backport][cmake] fix build by remove quotation marks on ExternalProject values
    AlwinEsch committed Aug 11, 2020
    Copy the full SHA
    9ebc8c0 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #18229 from AlwinEsch/fix-one-part

    [Addon Helper backport][addons] fix debian-addon-package-test.sh if in addon.xml.in version is more as 1 time
    AlwinEsch committed Aug 11, 2020
    Copy the full SHA
    0e37911 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2020

  1. TexturePacker: Do not leak image data memory

    Building Kodi with asan+lsan+ubsan breaks with the following error:
    
    =================================================================
    ==241706==ERROR: LeakSanitizer: detected memory leaks
    
    Direct leak of 69370335 byte(s) in 661 object(s) allocated from:
        #0 0x7fb290a737a7 in operator new[](unsigned long) (/usr/lib/x86_64-linux-gnu/libasan.so.6+0xab7a7)
        #1 0x563e2bed8b09 in PNGDecoder::LoadFile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, DecodedFrames&) (/build/kodi-18.8+dfsg1/kodi_build_x11/build/texturepacker/TexturePacker+0x17cb09)
        #2 0x563e2be71392 in DecoderManager::LoadFile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, DecodedFrames&) (/build/kodi-18.8+dfsg1/kodi_build_x11/build/texturepacker/TexturePacker+0x115392)
        #3 0x563e2be7d1bf in createBundle(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, double, unsigned int, bool) (/build/kodi-18.8+dfsg1/kodi_build_x11/build/texturepacker/TexturePacker+0x1211bf)
        #4 0x563e2be69990 in main (/build/kodi-18.8+dfsg1/kodi_build_x11/build/texturepacker/TexturePacker+0x10d990)
        #5 0x7fb28fbc7cc9 in __libc_start_main ../csu/libc-start.c:308
    
    SUMMARY: AddressSanitizer: 69370335 byte(s) leaked in 661 allocation(s).
    
    The root cause of the leak is decoder's FreeDecodedFrames never called.
    
    This commit fixes the leak by refactoring the following aspects:
    
     * Introducing the pointer to decoder object in the decoded frame,
     * Changing IDecoder::FreeDecodedFrames to IDecoder::FreeDecodedFrame
       cleaning single frame at a time
     * Moving iteration over frames to DecoderManager::FreeDecodedFrames
     * Removing unnecessary DecodedFrames.user
    
    Signed-off-by: Vasyl Gello <vasek.gello@gmail.com>
    basilgello committed Oct 16, 2020
    Copy the full SHA
    5dc076a View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2020

  1. added: as.xml option to disable Curl HTTP2

    arnova authored and wsnipex committed Oct 17, 2020
    Copy the full SHA
    c84d985 View commit details
    Browse the repository at this point in the history
  2. [curl] only use HTTP2 with SSL

    Cloudflare decided in it's infinite wisdom not to follow standards
    that allow HTTP2 requests without encryption.
    wsnipex committed Oct 17, 2020
    Copy the full SHA
    dbb8efc View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2020

  1. Copy the full SHA
    828b89b View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2020

  1. Merge pull request #18582 from wsnipex/http2_ssl_only_leia

    Backport: Http2 fixes
    DaveTBlake committed Oct 20, 2020
    Copy the full SHA
    e7a3a46 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #18604 from enen92/leia

    [Builtins][MediaWindow] Propagate window replace intention and set the start directory
    DaveTBlake committed Oct 20, 2020
    Copy the full SHA
    94bf77f View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    1945b57 View commit details
    Browse the repository at this point in the history
  4. Bump for 18.9 final

    DaveTBlake committed Oct 20, 2020
    Copy the full SHA
    490b653 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #18607 from DaveTBlake/fixrawkey_leia

    [Backport] Fix event server unable to send raw key strikes
    DaveTBlake committed Oct 20, 2020
    Copy the full SHA
    89b5860 View commit details
    Browse the repository at this point in the history
  6. [Android] Fix MediaCodec OES/EGL rendering

    peak3d authored and fritsch committed Oct 20, 2020
    Copy the full SHA
    1872121 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #18579 from basilgello/simplify-texturepacker-leia

    [BACKPORT][Leia]TexturePacker: Do not leak image data memory
    DaveTBlake committed Oct 20, 2020
    Copy the full SHA
    f48d890 View commit details
    Browse the repository at this point in the history
  8. Merge pull request #18609 from fritsch/mcbp

    [Android] Fix MediaCodec OES/EGL rendering
    DaveTBlake committed Oct 20, 2020
    Copy the full SHA
    2ca197c View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2020

  1. Merge pull request #18608 from DaveTBlake/bump18_9

    Bump for 18.9 final
    DaveTBlake committed Oct 23, 2020
    Copy the full SHA
    0655c2c View commit details
    Browse the repository at this point in the history